search

ArnoldSmith86 / virtualtabletop

a virtual surface in the browser on which you can play board, dice and card games
https://virtualtabletop.io
GNU General Public License v3.0
172 stars 31 forks source link

deck editor doesn't work with inheritFrom #864

Open Ingegneus opened 3 years ago

Ingegneus commented 3 years ago

a deck that has inheritFrom of another deck will have a blank deck editor. maybe this is intended behaviour but i think it would make sense to allow new cards to be uploaded. https://virtualtabletop.io/z1o8

bjalder26 commented 3 years ago

The deck editor is not "getting" the inherited faceTemplates, and that is causing an exception at the line below. image

robartsd commented 3 years ago

inheritFrom will not allow a deck to inherit cardTypes from one deck and define additional cardTypes. It would require a significant change to allow the inheriting deck to use card types from the master deck as well as its own card types. I doubt we want to go down that path.

Still, we should make the basic editors at least aware of inheritFrom and provide at least a message to the user indicating that the properties are being inherited from another widget. A link to edit the master widget would be nice. Options to stop inheriting specific properties (or altogether) which copy the previously inherited properties would be useful.