ArnoldV / Our.Umbraco.GMaps

Basic Google Maps with autocomplete property editor for Umbraco 8 and beyond!
MIT License
13 stars 30 forks source link

Deprecated Google Maps Library #176

Open abdulhade opened 2 months ago

abdulhade commented 2 months ago

Dear owner,

I hope you are doing well.

Could you help me please?

The warning bellow does my map not showing:

js?key=XXXXX&callback=XXXX.locationMap:200 As of February 21st, 2024, google.maps.Marker is deprecated. Please use google.maps.marker.AdvancedMarkerElement instead. At this time, google.maps.Marker is not scheduled to be discontinued, but google.maps.marker.AdvancedMarkerElement is recommended over google.maps.Marker. While google.maps.Marker will continue to receive bug fixes for any major regressions, existing bugs in google.maps.Marker will not be addressed. At least 12 months notice will be given before support is discontinued. Please see https://developers.google.com/maps/deprecations for additional details and https://developers.google.com/maps/documentation/javascript/advanced-markers/migration for the migration guide.

robertjf commented 2 months ago

@abdulhade is this on your front end implementation or in the Umbraco BackOffice?

abdulhade commented 2 months ago

Hi @robertjf it is implemented on my frontend.

robertjf commented 2 months ago

Ok, then you will need to review the Google documentation according to that error - we can assist with implementations of the plugin in the umbraco backoffice, but the front end is outside of our scope...

abdulhade commented 2 months ago

Sorry @robertjf . I don't understand why I need to review. It is your library whose responsable to render the google maps on my frontend.

Maybe, I didn't explain myself correctly.

I installed your plugin in my backoffice umbraco, I created datatypes that is using your Property Editor.

And then I implement this property on my documentType that renders on my frontend.

robertjf commented 2 months ago

@abdulhade we don't render the frontend for you, we only provide the map properties for you to use when rendering the map yourself. We render the map in the Umbraco BackOffice.

abdulhade commented 2 months ago

Hi @robertjf , I checked this error on BackOffice now and it is showing the same error.

robertjf commented 2 months ago

ok, can you please add some details to the error in the BackOffice - Dev Console logs, errors, etc.

abdulhade commented 2 months ago

Hi, @robertjf ,

I'm sorry, what kind of detail do you need? It is the same error. Do you need a print screen, like this? image

js?key=XXXXX&libraries=places&callback=googleMapsInitialized:671 As of February 21st, 2024, google.maps.Marker is deprecated. Please use google.maps.marker.AdvancedMarkerElement instead. At this time, google.maps.Marker is not scheduled to be discontinued, but google.maps.marker.AdvancedMarkerElement is recommended over google.maps.Marker. While google.maps.Marker will continue to receive bug fixes for any major regressions, existing bugs in google.maps.Marker will not be addressed. At least 12 months notice will be given before support is discontinued. Please see https://developers.google.com/maps/deprecations for additional details and https://developers.google.com/maps/documentation/javascript/advanced-markers/migration for the migration guide.

robertjf commented 2 months ago

@abdulhade can you tell me:

It also looks like you don't have the Google Maps API key registered correctly, which would be more the real reason the maps aren't displaying. The deprecation warnings about google.maps.Marker are just informational at this stage.

Take a look at the actual JavaScript API error messages.

abdulhade commented 2 months ago

Hi @robertjf

Version of Our.Umbraco.GMap:

About the Google Maps API Key, I did it because I can't show you this information.

Best regards, Abdul Abbas

JasonElkin commented 1 month ago

I've just come across this same warning.

It is an issue in the Backoffice, here's a screengrab from an Umbraco v13.5 site, with GMaps v3.0.2 installed: image

Everything still works fine, and it looks like there's no plan to remove the feature just yet - but it the warning has been flagged by one of our clients following a regression test.