search

Arnuh / ArmorEquipEvent

62 stars 43 forks source link

Even doesn't fire in 1.14.4 it seems #18

Open CollinHerber opened 5 years ago

CollinHerber commented 5 years ago

I've forked the repo to compile against 1.14.4 here: https://github.com/dream-horizon/ArmorEquipEvent

I've created the listener for the event here: https://github.com/dream-horizon/DreamHorizon-Enchantments/blob/master/src/main/java/com/dreamhorizon/enchantments/listeners/ArmorEquipListener.java

I've created logging statements locally and there are no statements being hit at the root level of the armorEquipEvent function.

Looking for assistance, or a way to reach you outside of github, to update this. Will gladly PR back once the resolution is complete as DH is all about the open source community.

Thank you, Collin Herber

CollinHerber commented 5 years ago

It should be noted that there are no errors of any sort when running PaperMC 1.14.4b144, with only DH-Core, DH-Enchants, and this lib. Just seems the event is not registered and fired off at the correct times.

I've tested every unequip method, and equip method I can think of.

Arnuh commented 5 years ago

I've tested b147 of paper and whatever my spigot was(15 versions behind) still properly activates the example equip event listener(as it's enabled on my test build) in the Main class.

Also I've stayed away from specifying a higher API version as it creates the possibility of breaking compatibility with older versions and this plugin is simple enough that I'm fine supporting older versions. And from what I've read Paper has a built in equip event and I would use that over this if such thing existed(again, not sure).

dalbodeule commented 4 years ago

I fixed some codes at #23 .

IDK for EventHandler's ignoreCancelled options. but it has problem for PlayerInteractEvent at Action.RIGHT_CLICK_AIR.