fix rightclick on air, elytra. migrate maven to gradle

Arnuh / ArmorEquipEvent

62 stars 43 forks source link

fix rightclick on air, elytra. migrate maven to gradle #23

Closed dalbodeule closed 4 years ago

dalbodeule commented 4 years ago

if player rightclick on air, doesn't catch event. i fix it.
if player equip elytra, doesn't catch event. i fix it.
migrate maven to gradle. but idk you want gradle build system

Arnuh commented 4 years ago

No such issue exists with "right clicking on air" and you never even modify anything related to such issue. And both people were unable to give proper reproduction steps and most likely did some kind of user error as the plugin still works perfectly in my testing of 1.14 AND 1.15

You're also correct I'm not looking to swap to gradle. No point if maven is already fully setup and works fine.

Good catch on missing Elytra though.

Arnuh commented 4 years ago

ok well.. after another report I now know actual reason right click on air didn't work and properly implemented a fix that wasn't just removing "ignoreCancelled"