search

Arnuh / ArmorEquipEvent

62 stars 43 forks source link

1.16 Support #28

Closed 132ikl closed 4 years ago

132ikl commented 4 years ago

In 1.16 Netheritie armor was added, and if the plugin uses a lower api-version than 1.16 for whatever reason the Material of Netherite armor appears as AIR. If you update the api-version to 1.16 this will likely break lower version compatibility, so I'm not sure how you want to handle this. Either way, a working 1.16 fork can be found at 132ikl/ArmorEquipEvent.

Arnuh commented 4 years ago

Well I forgot to specify this issue in the commit but https://github.com/Arnuh/ArmorEquipEvent/commit/2bad3f3f24106bc2596093d0e58aaea8e48b09c5 now specifies the api version of 1.14 which seems to solve the problem. No reason bumping the version higher since the plugin doesn't use anything in a higher api version.

132ikl commented 4 years ago

Perfect. Could you also make a release? Thanks

Arnuh commented 4 years ago

https://jenkins.arnah.ca/view/Minecraft/job/ArmorEquipEvent/ will have latest builds. I'll do a proper release on Github/Spigot once I know nothing else is broken in 1.16