cptResourceDemand - Australian date issue

[AronGahagan]

Problem:

Australian client reports date format issues. Where else does this issue exist?

Solution:

TBD - need to figure out checking against regional settings vs. only the Project Setting for DateFormat.

Todo:

• [x] assign this issue
• [x] label the issue for enhancement or bug
• [x] label the issue with codemodule (so fixes can be aggregated and hotfixed together)
• [x] checkout appropriate branch and create topic branch
• [x] design, code and test
• [x] update codemodule x.y.z
• [x] update CurrentVersions.xml manually
• [x] commit changes prefix comment with Issue #XXX -
• [x] merge topic into appropriate branch(es) and push
• [x] delete topic branch

[AronGahagan]

Application.LocaleName = "en-us" ; "en-au" add a setting on the Settings form? default to user's locale? how many formats? where to change? see Windows Locales

[AronGahagan]

yikes:

git grep -c -E 'DateFormat|FormatDate|Format.*yy|mm\/dd\/yyyy' | awk -F: '{ sum += $2 } END { print sum }'

Admin/cptAdmin_bas.bas:1
Backbone/cptBackbone_bas.bas:1
Calendar/cptFiscal_bas.bas:1
Calendar/cptFiscal_frm.frm:3
Core/cptCore_bas.bas:2
CostRateTables/cptCostRateTables_bas.bas:1
CustomFields/cptDataDictionary_bas.bas:1
Integration/cptIMSCobraExport_bas.bas:2
Integration/cptIMSCobraExport_frm.frm:5
Integration/cptIMSCobraExport_frm.frx:1
Integration/cptIntegration_frm.frm:2
Metrics/cptDECM_bas.bas:4
Metrics/cptDECM_frm.frm:1
Metrics/cptMetrics_bas.bas:52
ResourceDemand/cptResourceDemand_bas.bas:11
Status/cptAgeDates_bas.bas:14
Status/cptAgeDates_frm.frm:1
Status/cptSmartDuration_bas.bas:1
Status/cptSmartDuration_frm.frm:1
Status/cptStatusSheetImport_bas.bas:61
Status/cptStatusSheet_bas.bas:34
Status/cptStatusSheet_frm.frm:16
Status/cptTaskHistory_bas.bas:12
Text/cptText_bas.bas:1
Trace/cptCriticalPathTools_bas.bas:4
Trace/cptCriticalPath_bas.bas:8
Trace/cptNetworkBrowser_bas.bas:13
cptSetup_bas.bas:43

git grep -c -E 'DateFormat|FormatDate|Format.*yy|mm\/dd\/yy' | awk -F: '{ sum += $2 } END { print sum }'
297

[AronGahagan]

I think if we eliminate all hard-coded date formats for the named vbDateTimeFormats that should do the trick: vbGeneralDate; vbLongDate; vbShortDate; vbLongTime; vbShortTime. I think we can rely on the user's Locale Settings to make the formats. Need to confirm folder path/status dates and file name assumptions, etc.