cptDataDictionary - account for '-' in a custom field name

[AronGahagan]

Problem:

User RG reports glitch when custom field contains "-"

CustomFields/cptDataDictionary_bas.bas:
198:          UCase(Replace(FieldConstantToFieldName(lngField), " ", "_"))
205:          UCase(Replace(FieldConstantToFieldName(lngField), " ", "_"))
281:          UCase(Replace(FieldConstantToFieldName(lngField), " ", "_"))
287:          UCase(Replace(FieldConstantToFieldName(lngField), " ", "_"))

Solution:

CustomFields/cptDataDictionary_bas.bas:
198:          UCase(Replace(Replace(FieldConstantToFieldName(lngField), " ", "_"),"-","_"))
205:          UCase(Replace(Replace(FieldConstantToFieldName(lngField), " ", "_"),"-","_"))
281:          UCase(Replace(Replace(FieldConstantToFieldName(lngField), " ", "_"),"-","_"))
287:          UCase(Replace(Replace(FieldConstantToFieldName(lngField), " ", "_"),"-","_"))

Todo:

• [x] assign this issue
• [x] label the issue for enhancement or bug
• [x] label the issue with codemodule (so fixes can be aggregated and hotfixed together)
• [x] checkout appropriate branch and create topic branch
• [x] design, code and test
• [x] update codemodule x.y.z
• [x] update CurrentVersions.xml manually
• [x] commit changes prefix comment with Issue #XXX -
• [x] merge topic into appropriate branch(es) and push
• [x] delete topic branch