search

AronGahagan / cpt-dev

Code repository for the ClearPlan Toolbar
https://www.ClearPlanConsulting.com
3 stars 1 forks source link

Question: is tAss.FStart a valid property assignment in cptIMSExport_bas? #390

Closed AronGahagan closed 2 months ago

AronGahagan commented 2 months ago

Just a question: in the below section of code, should tAss.FStart be tAss.Start?

 444                                 If .AssignmentFStart = "NA" Then 'v3.3.0
 445                                     .AssignmentFStart = tAss.Start
 446                                 Else
 - 447                                     If tAss.FStart < .AssignmentFStart Then '<--- should this
'+ 447                                     If tAss.Start < .AssignmentFStart Then '<--- be this?
 448                                         .AssignmentFStart = tAss.Start
 449                                     End If
 450                                 End If
 451
 452                                 If .AssignmentFFinish = "NA" Then 'v3.3.0
 453                                     .AssignmentFFinish = tAss.Finish
 454                                 Else
 455                                     If tAss.Finish > .AssignmentFFinish Then
 456                                         .AssignmentFFinish = tAss.Finish
 457                                     End If
 458                                 End If

tAss.FStart is only cited once:

$ git grep -whoE '\S*\.FStart' | sort | uniq -c
      5 .FStart # these 5 instances belong to different objects/arrays
     44 ACTarray(X).FStart
     48 ACTarray(i).FStart
     12 Format(ACTarray(i).FStart
      1 tAss.FStart

loc in context:

https://github.com/AronGahagan/cpt-dev/blob/e42dcca440d3944247597397c84770565d172b16/Integration/cptIMSCobraExport_bas.bas#L447