search

Arquisoft / InciManager_i2b

InciManager_i2b
MIT License
1 stars 2 forks source link

Saving incidents #22

Closed carmee-en closed 6 years ago

carmee-en commented 6 years ago

This is my initial implementation. Any suggestions are welcome.

The configuration file is parsed and for each element it finds a new function with Incident as parameter and that returns boolean is created. Then, before saving the incident to the repository it is checked if the incident object fulfills any of the predicates or not.

codecov[bot] commented 6 years ago

Codecov Report

Merging #22 into master will increase coverage by 2.71%. The diff coverage is 82.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #22      +/-   ##
============================================
+ Coverage     63.39%   66.11%   +2.71%     
- Complexity       77       95      +18     
============================================
  Files            19       20       +1     
  Lines           306      360      +54     
  Branches         29       38       +9     
============================================
+ Hits            194      238      +44     
- Misses          102      108       +6     
- Partials         10       14       +4
Impacted Files Coverage Δ Complexity Δ
...a/com/uniovi/services/InsertSampleDataService.java 76.92% <100%> (+1.92%) 2 <0> (ø) :arrow_down:
...ain/java/com/uniovi/services/IncidentsService.java 53.33% <66.66%> (-0.52%) 5 <1> (ø)
...rc/main/java/com/uniovi/util/IncidentSelector.java 82% <82%> (ø) 18 <18> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0716380...7563b77. Read the comment docs.