Closed alejgh closed 6 years ago
Merging #36 into master will increase coverage by
6.64%
. The diff coverage is84.61%
.
@@ Coverage Diff @@
## master #36 +/- ##
============================================
+ Coverage 74.74% 81.39% +6.64%
- Complexity 121 138 +17
============================================
Files 22 22
Lines 396 430 +34
Branches 44 47 +3
============================================
+ Hits 296 350 +54
+ Misses 81 59 -22
- Partials 19 21 +2
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
src/main/java/com/uniovi/entities/AgentInfo.java | 51.21% <ø> (ø) |
12 <0> (ø) |
:arrow_down: |
src/main/java/com/uniovi/entities/LatLng.java | 100% <ø> (+16.66%) |
3 <0> (+1) |
:arrow_up: |
...rc/main/java/com/uniovi/services/KafkaService.java | 11.11% <0%> (ø) |
2 <0> (ø) |
:arrow_down: |
...ava/com/uniovi/controllers/IncidentController.java | 100% <100%> (ø) |
5 <2> (+2) |
:arrow_up: |
...a/com/uniovi/services/InsertSampleDataService.java | 100% <100%> (+31.03%) |
3 <2> (+1) |
:arrow_up: |
...om/uniovi/controllers/IncidentsInfoController.java | 95.23% <100%> (+1.9%) |
8 <2> (+2) |
:arrow_up: |
src/main/java/com/uniovi/entities/Incident.java | 89.06% <100%> (+24.06%) |
28 <2> (+7) |
:arrow_up: |
...ain/java/com/uniovi/services/IncidentsService.java | 100% <100%> (ø) |
10 <2> (+1) |
:arrow_up: |
...c/main/java/com/uniovi/services/AgentsService.java | 76.92% <64.7%> (-6.42%) |
7 <1> (+1) |
|
...in/java/com/uniovi/repositories/CSVFileParser.java | 87.5% <90%> (+0.83%) |
15 <2> (+2) |
:arrow_up: |
... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d81fa82...0d5bae7. Read the comment docs.
Some of the issues pointed out by Codacy in the JavaScript files are completely illogical and solving them will produce less understandable and maintanable code overall. That's why I included a codacy.yml file ignoring the javascript files (I solved most of the issues there nevertheless, except the ones that didn't make sense).
Closes #28 Added a new chat interface that allows users to create incidents. You need to be logged in to access this view (either by going directly to "incident/create" or clicking a button in the incidents view). I also added some documentation, selenium tests, and changed a bit the functionality of the log in system.