Closed alejgh closed 6 years ago
Merging #39 into master will increase coverage by
3.18%
. The diff coverage is72%
.
@@ Coverage Diff @@
## master #39 +/- ##
===========================================
+ Coverage 81.01% 84.2% +3.18%
- Complexity 162 169 +7
===========================================
Files 24 25 +1
Lines 495 500 +5
Branches 57 58 +1
===========================================
+ Hits 401 421 +20
+ Misses 66 53 -13
+ Partials 28 26 -2
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...in/java/com/uniovi/repositories/CSVFileParser.java | 91.17% <ø> (+3.67%) |
11 <0> (-4) |
:arrow_down: |
...ava/com/uniovi/main/InciManagerI2bApplication.java | 33.33% <ø> (ø) |
1 <0> (ø) |
:arrow_down: |
...ain/java/com/uniovi/services/IncidentsService.java | 100% <ø> (ø) |
10 <0> (ø) |
:arrow_down: |
...ava/com/uniovi/controllers/IncidentController.java | 100% <ø> (ø) |
5 <0> (ø) |
:arrow_down: |
src/main/java/com/uniovi/entities/Incident.java | 89.55% <ø> (ø) |
30 <0> (ø) |
:arrow_down: |
src/main/java/com/uniovi/entities/AgentInfo.java | 63.41% <ø> (+2.43%) |
14 <0> (ø) |
:arrow_down: |
src/main/java/com/uniovi/entities/LatLng.java | 100% <ø> (ø) |
3 <0> (ø) |
:arrow_down: |
src/main/java/com/uniovi/kafka/KafkaConfig.java | 100% <ø> (ø) |
4 <0> (?) |
|
...rc/main/java/com/uniovi/mongo/TestMongoConfig.java | 0% <0%> (ø) |
0 <0> (?) |
|
...a/com/uniovi/util/IncidentPropertiesConverter.java | 0% <0%> (-100%) |
0 <0> (-3) |
|
... and 14 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f4752aa...64ac5d0. Read the comment docs.
We will be using (at least for this deliverable) a shared mongo database with the InciDashboard team. In the future I would like to use only materialized views from Kafka streams to store information, but for now this will be the easiest solution. I also added an embedded mongo database for tests, to avoid running the server whenever we run the tests.