search

Arquisoft / InciManager_i2b

InciManager_i2b
MIT License
1 stars 2 forks source link

Last cucumber tests #58

Closed ulitol97 closed 6 years ago

ulitol97 commented 6 years ago

Cucumber tests implemented for:

Covering #49

codecov[bot] commented 6 years ago

Codecov Report

Merging #58 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             master   #58   +/-   ##
======================================
  Coverage        95%   95%           
  Complexity      210   210           
======================================
  Files            24    24           
  Lines           521   521           
  Branches         63    63           
======================================
  Hits            495   495           
  Misses           13    13           
  Partials         13    13

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88029fe...5fdb6cc. Read the comment docs.

ulitol97 commented 6 years ago

IMO everything is fine, I'll let you review it just in case before merging.

alejgh commented 6 years ago

Yeah, everything looks fine. You can merge new tests without reviews if you want, don't worry about that.

Btw, thanks for fixing the typo in a_person_with_usrname_and_password, I saw it once and I forgot to change it 😆

ulitol97 commented 6 years ago

Perfect! And you're welcome :P