search

Arquisoft / Loader_i3a

Loader module
The Unlicense
5 stars 3 forks source link

New location format checking when parsing #37

Closed eleallegue closed 6 years ago

eleallegue commented 6 years ago

The whole system has changed, and so the new format is lat, long being lat a double representing the latitude, and long a double representing the longitude. The whole tests must change, because the new format of the excel files, must change too for taking into account the new requirements. Excel doesn't allow to write a comma between two doubles, so they must be written in two different columns, and then connected into a string when creating the Agent object. Solving issue #36

codecov[bot] commented 6 years ago

Codecov Report

Merging #37 into master will increase coverage by 1.17%. The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #37      +/-   ##
============================================
+ Coverage     70.76%   71.94%   +1.17%     
- Complexity       37       40       +3     
============================================
  Files             5        5              
  Lines           130      139       +9     
  Branches         17       19       +2     
============================================
+ Hits             92      100       +8     
  Misses           37       37              
- Partials          1        2       +1
Impacted Files Coverage Δ Complexity Δ
.../java/es/uniovi/asw/loader_client/types/Agent.java 93.75% <100%> (ø) 9 <0> (ø) :arrow_down:
...s/uniovi/asw/loader_client/parser/ExcelParser.java 95.77% <91.66%> (-1%) 22 <1> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4b3d4f...d778688. Read the comment docs.