Arquisoft / dechat_es1b

DeChat ES1B
https://arquisoft.github.io/dechat_es1b/
MIT License
6 stars 4 forks source link

Refactoring, new modules, tests #38

Closed srensamblador closed 5 years ago

srensamblador commented 5 years ago

Changes

Notes

Opinions?

srensamblador commented 5 years ago

It looks great, just a question. After creating the POD reader (uses ldflex). May we insert it into the ldflex-queries class? or should be better in another one.

Good question. This is case would be a module using another one. POD reader doesnt belong inside LDFlex queries but it's a library on its own so to speak. Therefore, it should be its own module in its own file that imports (requires) LDFlex.

srensamblador commented 5 years ago

Sorry about the core.js mess, i didn't realize it would be such a hassle. It's great that we now have cleaner modules, let's keep it this way from now on.

It's not a big deal, it's just better to start clean before it gets out of hand