Arquisoft / dechat_es1b

DeChat ES1B
https://arquisoft.github.io/dechat_es1b/
MIT License
6 stars 4 forks source link

New nav in index.html #42

Closed MarcosCl98 closed 5 years ago

MarcosCl98 commented 5 years ago

I have created a nav in index.html.

It would look like this:

69968

The design is simple, but I think it would improve visually quite as it was before, if you like we can merge it, any criticism is allowed. :)

martinlacorrona commented 5 years ago

Its feel good

srensamblador commented 5 years ago

It's pretty but I'm worried integrating the navbar now would make the rest hard to work with JQuery, My recommendation would be to save your navbar for now and integrate it when the chat is already working.

For now simple views to make sure the chat works and once we get there we can see how to integrate the navigation.

What we can do is remove the navigation buttons in the left for now, and left the previous ones in the view itself. In the nav we can have the login/logout and a logo or DeChat text on the left for now, like in the chess web app.

What do you think?

LuisBoto commented 5 years ago

As Samuel says, it really looks good but maybe we should save it for later. I think we could just let the branch sit for now and merge it once we are a bit more advanced with the interface, just so we deal with it when we are ready

MarcosCl98 commented 5 years ago

But my question is, what will affect the nav, i mean, are still buttons, with the same id, if someone added for example the functionality of viewing contacts, if you use the id of the button, in this case friends, is the same that of the old html, with which the code in javascript would be the same. I do not know if I explained well ... I really just modified the look, the elements are the same. If someone can explain it to me, I would appreciate it.