search

Arquisoft / dechat_es1b

DeChat ES1B
https://arquisoft.github.io/dechat_es1b/
MIT License
6 stars 4 forks source link

Features/refactor code #75

Closed martinlacorrona closed 5 years ago

martinlacorrona commented 5 years ago

Now UI only need class Chat.js for communicate with Chat Logic.

martinlacorrona commented 5 years ago

I have updated now the documentation.

LuisBoto commented 5 years ago

I wanted to ask @martinlacorrona and @uo257493 about the TextParser script and the slashes method. I have been looking at the code and i don't quite get why this is necessary at all, since slashes are located only at the start and end of the file. Therefore, parsing seems futile; i think code never seems to enter the if blocks (file is always written in the same way to POD) and ends up returning just the JSON.parse of parts[1], which is basically the whole file.

Please give me some insight on this, i think i may be missing something.

srensamblador commented 5 years ago

Tests are :ok_hand:

uo257493 commented 5 years ago

@LuisBoto yes you are right main idea to use the four slashes were under the pretext to read a full RDF avoiding the use of a native library to treat this kind of file. For sure now it will be removed. If everybody agree i'll proceed