SergioArroni commented 2 years ago

Soluciona los Code Smells y la duplicidad en el header esta bien?

UO232627 commented 2 years ago

Solucionado el code smell. La duplicidad sale en un test, por lo que no deberíamos preocuparnos.

codecov[bot] commented 2 years ago

Codecov Report

Merging #270 (f9df12a) into Developer (ed0bc52) will increase coverage by 1.68%. The diff coverage is 71.79%.

@@              Coverage Diff              @@
##           Developer     #270      +/-   ##
=============================================
+ Coverage      46.00%   47.69%   +1.68%     
=============================================
  Files             20       20              
  Lines            426      434       +8     
  Branches          84       99      +15     
=============================================
+ Hits             196      207      +11     
+ Misses           230      227       -3

Impacted Files	Coverage Δ
webapp/src/App.tsx	`100.00% <ø> (ø)`
webapp/src/User.tsx	`60.00% <0.00%> (ø)`
webapp/src/components/Cart.tsx	`84.61% <0.00%> (ø)`
webapp/src/index.tsx	`0.00% <ø> (ø)`
webapp/src/pages/CrudAddPage.tsx	`56.52% <ø> (ø)`
webapp/src/pages/CrudDeletePage.tsx	`64.28% <ø> (ø)`
webapp/src/pages/CrudEditPage.tsx	`56.00% <ø> (ø)`
webapp/src/pages/LoginPage.tsx	`35.48% <ø> (ø)`
webapp/src/pages/SignUpPage.tsx	`48.64% <ø> (ø)`
webapp/src/pages/OrdersPage.tsx	`66.66% <44.44%> (-8.34%)`	:arrow_down:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed0bc52...f9df12a. Read the comment docs.

sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
5.2% Duplication

Arquisoft / dede_es3c

Alejandro main entrega 4 #270

Codecov Report