New filter options, owner aditions and feedback

Arquisoft / lomap_en1b

LoMap Software architecture group en1b course 2022_23

http://lomap.mariopdev.com

1 stars 1 forks source link

New filter options, owner aditions and feedback #110

Open UO278249 opened 1 year ago

UO278249 commented 1 year ago

There has been multiple changes on the map view:

Feedback is given while loading and succesfully adding a location and review.
Owner is shown on reviews and locations.
Two filter options for my locations and friend locations added.
Added feedback on friends view.
Changed display on photo preview on add review.

uo276670 commented 1 year ago

The new parts seem to be working correclty but I am getting an error with our type MapMarker:

The type inside the types fule of the webapp has the new fields, but the our map file doesnt detect those new changes "Property 'isShared' does not exist on type 'MapMarker'. Did you mean 'shared'?" even if 'shared' was changed to 'isShared'.
But this seems to give no real errors, needs checking when parameters come through the RestAPI

The new box for the owner of the location doesnt correctly match the popUp box

uo276670 commented 1 year ago

Also we will need some twicking on the filters. Right now the names are confusing. My location, Public locations, Friend locations seems a little bit confusing

Public locations reffer to my public locations or public locations in general?
My locations show both my public and private location?

Also it could be great If we could have on one column the list with the types, monument, sight, etc... and then another column with the other kind of filters like, my locations and friends locations

UO278249 commented 1 year ago

Branch updated due to comments filter changed and some more corrections and small aditions have been added.