search

Arquisoft / lomap_en2b

LoMap Software architecture group en2b course 2022_23
https://arquisoft.github.io/lomap_en2b
1 stars 1 forks source link

About the map API #42

Closed jjgancfer closed 1 year ago

jjgancfer commented 1 year ago

As some of you might have noticed, I have already working on the map implementation, starting last Friday and working on it since then. Thing is, the official Mapbox React example the documentation proportionates does not work (at least for me) and efforts to find other solutions online were moot since they were too complex for an amateur in React like me to understand.

So, today I tried my hand doing it using the other library/API we had considered, adding a React-specific dependency and updating the React-related packages due to compatibility issues. And it worked. So, would you like to continue using Mapbox, or go ahead with the other implementation?

plg22 commented 1 year ago

I think as you have used leaflet and it worked, and you could not make it work with MapBox, we should commit to what it´s working.

andrrsin commented 1 year ago

I agree, today we should revise your version, as long as it works fine. It is perfect for me, as you said the Mapbox was an example It's not a constraint. I'm going to review the PR to have it added

jjgancfer commented 1 year ago

Closed as the issue has been solved.