Unitary Tests

[FdezAriasSara]

-Unitary tests for rendering

• [x] Login View
• [x] Header elements
• [x] Filter menu
• [x] Profile menu
• [x] Log Out
• [ ] Detailed information of a location
• [ ] Review Section
• [x] Add new location form
• [ ] Achieving an overall coverage of 80%

[FdezAriasSara]

@Batuhanbyr @RaduSeba

Guys one thing. in order to be able to make tests i will be adding two things:

• aria-labels: they help me find elements with jest plus they are helpful for accessibilty of blind users.
• in mapView, i will need to change this:

It prevents every other part ( header, and all info lists to appear) when loading the map goes wrong for some reason. That is absolutely fine, but it makes it impossible to test, since tests wont start a session and therefore no maps petition is done .

The new version will do the following:

I created a simple error view to be displayed instead of the map:

that way , the header and submenus render and i can test them

[FdezAriasSara]

I just realized I made a mistake when modifying the sonarcloud configuration file, that would make the coverage be equal to 0%

[FdezAriasSara]

Good morning,@pglez82

I was not able to get sonarcloud to percieve any code coverage.

I tried it all:

• changing sonar language from ts to js , since that's what we are using
• changing sonar exclusions since , again we are using javascript , and test will be .test.js instead of .test.ts
• i changed the depth /shallow problem mentioned in Arquisoft Faq https://github.com/Arquisoft/faq/issues/42
• Also i changed the sonarcloud action version as you told me and as it's said in the faq too https://github.com/Arquisoft/faq/issues/45
• I changed the directory for the scanner to look at because i wanted to test some views outside the component folder *i tought for a second it could be that tests would not run when doing npm test... but they do?So another possible solution i think is discarded..

im trying to test more in depth, like functions being called, but i cannot always do that since some of them( the majority ) are handlers and are just arrowfunctions not being exported...

im not quite sure if the problem is sonarcloud file, my tests being bad or the way our code is that allows no coverage somehow?

here's the link to the sonarcloud report just in case it might be usefull.. https://sonarcloud.io/component_measures?metric=new_coverage&selected=Arquisoft_lomap_en3b%3Awebapp%2Fsrc%2Fcomponents%2FHeader.js&view=list&id=Arquisoft_lomap_en3b

I don't know what else to do with it..

Thank you in advance

Sara

[pglez82]

Can you add to package.json:

"test": "react-scripts test", the option --coverage?

Seems to me that it is not generating any coverage report.

[FdezAriasSara]

Can you add to package.json:

"test": "react-scripts test", the option --coverage?

Seems to me that it is not generating any coverage report.

Thank you so much..