search

Arquisoft / lomap_en3b

LoMap Software architecture group en3b course 2022_23
https://arquisoft.github.io/lomap_en3b
6 stars 0 forks source link

Review Section #69

Open Batuhanbyr opened 1 year ago

Batuhanbyr commented 1 year ago

problemimg

When an image was added in the comment section, the HTML code appeared in the comment and the comment section was too short. Additionally, the image and rating sections in the comment were not aligned properly. I have addressed these issues and added an emoji feature to the comment section. However, I am not entirely sure about the design and would like to ask all team members if they have any suggestions or changes they would like to make regarding the comment section design.

lomap1

FdezAriasSara commented 1 year ago

I think the changes look amazing! the aligment really does bring it up all together I hadn't noticed the code appearing in the comment when you added the picture so thanks for solving that! regarding the desging, im really happy with how it is now, the only suggestion i would make would be to increase the size of the add a coment part. for example using this: image

image

it's basically just to add that prop. and it will autoadapt to the size of the container :)

link to the doc of material ui

Batuhanbyr commented 1 year ago

thank you, I will do that :)

FdezAriasSara commented 1 year ago

hi , again , i want to remark how amazing it looks

but when i checked the pr, i realized this happens (i think it happens only in the location detail part) : image

could you make it to be inside the white box? so it has a scroll bar or something when the screen is smaller?

Thank you so much if you have any problem let me know ill try to help

sorry for asking things all the time 😢

Batuhanbyr commented 1 year ago

I apologize for this design mistake, I have fixed it. Additionally, I have changed the checkboxes in the filtering section to icon buttons, which I think looks good, but if you don't like it, I can remove it. Please let me know of any other things you have noticed so that I can fix them. AÇIKLAMA FİLTRELEME

FdezAriasSara commented 1 year ago

I apologize for this design mistake, I have fixed it. Additionally, I have changed the checkboxes in the filtering section to icon buttons, which I think looks good, but if you don't like it, I can remove it. Please let me know of any other things you have noticed so that I can fix them. AÇIKLAMA FİLTRELEME

Please dont apologize you did a great job!

I love the changes thank you :) <3,

my only question is: Do the filters allow pressing more than one??? Thats why i used checkboxes. If they do , thats amazing and i like it more than what i did!:)