Arquisoft / viade_en1b

Viade en1b
https://arquisoft.github.io/viade_en1b/
MIT License
5 stars 5 forks source link

Solid modifications #142

Closed themrcesi closed 4 years ago

themrcesi commented 4 years ago

Okay guys, after almost more than 15 hours working... @alvarezGarciaMarcos and I finally achieved everything related with SOLID.

Now, we are able to share routes modifying permissions, uploading comments, uploading images, view shared routes with all the linked content...you know, everything. If you want to try it, first of all remove /viade in your POD, be sure of removing everything inside please.

@alvarogarinf 's way of reading images perfectly worked.

So now, tests are failing, only a few of them.

@lamasumas can you check all the internationalization "errors" and fix them?

We need also to check css of the new files and so on... In the meating we talk about this.

codecov[bot] commented 4 years ago

Codecov Report

Merging #142 into dev will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #142   +/-   ##
=======================================
  Coverage   74.81%   74.81%           
=======================================
  Files          53       53           
  Lines         790      790           
  Branches       72       72           
=======================================
  Hits          591      591           
  Misses        182      182           
  Partials       17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6a53c2...d6a53c2. Read the comment docs.