Closed InigoGutierrez closed 4 years ago
Merging #154 into solid_modifications will decrease coverage by
0.49%
. The diff coverage is79.48%
.
@@ Coverage Diff @@
## solid_modifications #154 +/- ##
=======================================================
- Coverage 74.54% 74.05% -0.50%
=======================================================
Files 53 53
Lines 774 790 +16
Branches 71 73 +2
=======================================================
+ Hits 577 585 +8
- Misses 181 189 +8
Partials 16 16
Impacted Files | Coverage Δ | |
---|---|---|
src/solid/routes.js | 87.50% <79.48%> (-3.13%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8fc9a07...cc96bb7. Read the comment docs.
Hm, it seems coverage has decreased a bit. This is mainly due to the new image handling stuff, but I see quite difficult to cover that and would be little gain. I will upload a fix of a missing bracket and merge now.
Oh, I see that you already fixed that missing bracket. I will add just the return null that was there so we are sure that the function returns null when it fails, since a check for null is made later.
I made so routes in the user's folder are checked to be .jsonld files and that if any of then can't be read or causes an error when transforming to our json object the route is ignored. I also made so the sharedRoutes file is ignored if it is wrong, and that if some of its urls is wrong it is also ignored.
I added
console.log()
calls to show the errors, since I think they are justified here and it can help if something is wrong during the presentation. If would prefer for them to "fail" silently we could talk about it.Maybe more checks in other places should be added, I leave the PR here for the moment for visibility.