search

Arquisoft / viade_en3a

Viade En3A
https://arquisoft.github.io/viade_en3a/
1 stars 4 forks source link

Add a place search feature to route creation map #143

Closed fincamd closed 4 years ago

fincamd commented 4 years ago

Route creation map not very usable. Users find themselves lost. Maybe we need to add a search feature to go to a specific point on the globe and start the route from there.

oscar134 commented 4 years ago

I inserted a first prototype of how to search in the RouteCreation window. What do you think about it? I didn't like the already created components in npm for searching so I'm constructing my own. It has many possiblities. Like suggesting multiple places to go to the user. Do you think we should put much effort in having a very good searching system or is better concentrating in other issues and leave it very similar to what we have now?

fincamd commented 4 years ago

Well, what you did is impressive. I think it provides enough usability for what was suggested in the review. For now it will suffice, I think we should now focus in polishing other issues we currently have and later come back if some time is left.

oscar134 commented 4 years ago

Ok. As soon as possible I will add some tests to this, and some error control to finish it.

fincamd commented 4 years ago

Got it. Great job mate. :D

oscar134 commented 4 years ago

Basic implementation done. Can be enhaced but I will focus on things with more priority.

fincamd commented 4 years ago

I think that we could close this issue since it wont be worked on for a while until we wrap things up.

If you agree simply close this. We don't really need this open anymore.

oscar134 commented 4 years ago

Ok