Arquisoft / viade_en3a

Viade En3A
https://arquisoft.github.io/viade_en3a/
1 stars 4 forks source link

Feature fix map creation #164

Closed oscar134 closed 4 years ago

oscar134 commented 4 years ago

Remove description minimum length validation, add real author to the route, searching bar not yet.

codecov[bot] commented 4 years ago

Codecov Report

Merging #164 into development will increase coverage by 0.54%. The diff coverage is 36.11%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #164      +/-   ##
===============================================
+ Coverage        32.49%   33.03%   +0.54%     
===============================================
  Files               27       29       +2     
  Lines              437      454      +17     
  Branches            31       31              
===============================================
+ Hits               142      150       +8     
- Misses             270      279       +9     
  Partials            25       25              
Impacted Files Coverage Δ
src/i18n.js 0.00% <ø> (ø)
src/pages/Home.js 0.00% <0.00%> (-18.19%) :arrow_down:
src/model/Util.js 16.66% <16.66%> (ø)
src/pages/MapCreation.js 26.82% <25.00%> (+2.43%) :arrow_up:
src/components/searchBar/SearchBar.js 50.00% <50.00%> (ø)
src/components/editableMap/EditableMap.js 56.00% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 261e3c6...d9f7d83. Read the comment docs.

oscar134 commented 4 years ago

This branch corresponds to the Search Bar Issue (#143). Is available to be reviewed. The problem that @jesQM mentions above is not solved, as @nicomencia is working on it.

nicomencia commented 4 years ago

There is still a bug. When the translation is called the username disapears.