search

Arquisoft / viade_en3a

Viade En3A
https://arquisoft.github.io/viade_en3a/
1 stars 4 forks source link

Correct home and profile page to get the username correctly #165

Closed nicomencia closed 4 years ago

nicomencia commented 4 years ago

Modify the home and profile view of the username in order to get it correctly without all the id. Also get from the pod more info for the profile.

oscar134 commented 4 years ago

I have extracted the get username functionality in the home view to another class because I needed to use it in another part. Its query needs to be changed in order to be compatible with inrupt. Maybe you can take what I have refactored in my branch.

oscar134 commented 4 years ago

Jesus and I talked a bit about this in the opened pull request

jesQM commented 4 years ago

Perhaps that class (src/model/Util.js) can be used to centralize all stuff regarding user details: friends, username... Just to have all ldflex query methods (or any other format) in one same class.

nicomencia commented 4 years ago

Yes I think you are right, that might be the best idea in order to centralice all the methods getting info from the POD, in order to be used through the app

oscar134 commented 4 years ago

Ok. You can review my pull request and merge if you want or work over it.

nicomencia commented 4 years ago

Getting name correctly in home and profile page using ldflex from utils.js in feature-profile-info. I'll keep working in more attributes.

nicomencia commented 4 years ago

Only name is under http://xmlns.com/foaf/0.1/ the rest of attributes are under http://www.w3.org/2006/vcard/ns# so I cannot access from ldflex queries.

nicomencia commented 4 years ago

Name in profile works both in solid.community and inrupt providers

nicomencia commented 4 years ago

Username, address, phone and email displayed correctly