search

Arquisoft / viade_en3a

Viade En3A
https://arquisoft.github.io/viade_en3a/
1 stars 4 forks source link

Better alerts in route creation #168

Closed oscar134 closed 4 years ago

oscar134 commented 4 years ago

I have changed the ugly navigator alerts by "react-toastify" library alerts. What do you think about them? Any idea on how to internationalize them? I also added loading icons while downloading and uploading routes.

codecov[bot] commented 4 years ago

Codecov Report

Merging #168 into development will increase coverage by 4.24%. The diff coverage is 81.81%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #168      +/-   ##
===============================================
+ Coverage        33.03%   37.28%   +4.24%     
===============================================
  Files               29       29              
  Lines              454      464      +10     
  Branches            31       32       +1     
===============================================
+ Hits               150      173      +23     
+ Misses             279      269      -10     
+ Partials            25       22       -3
Impacted Files Coverage Δ
src/i18n.js 0.00% <ø> (ø)
src/components/routeList/RouteList.js 59.37% <75.00%> (+2.70%) :arrow_up:
src/pages/MapCreation.js 65.30% <82.35%> (+38.47%) :arrow_up:
src/components/editableMap/EditableMap.js 56.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 06d8994...60c6f29. Read the comment docs.