search

Arquisoft / viade_en3a

Viade En3A
https://arquisoft.github.io/viade_en3a/
1 stars 4 forks source link

Several modifications. Read description #177

Closed fincamd closed 4 years ago

fincamd commented 4 years ago

In previous version, creating a route wouldn't calculate elevations until the very last moment before uploading it to the POD.

Now it does every single time the map is modified asynchronously. It works although we'd probably need to check whether or not there are points without altitude when trying to upload it. and so warn the user with a toast.

I mean, right before uploading it -the user clicks "upload to pod"-, we check if some point is waiting for its altitude with some boolean value in their class -RoutePoint-. This way we improve usability and data consistency inside the POD.

fincamd commented 4 years ago

I have improved the performance when creating a route. As the commit says, the points' elevation is calculated asynchronously. When fetched, the graph on the right hand side of the map (RouteCreation) is updated so it displays the new altitude. I'd probably need to check the way I upload the graph so it doesn't move all over the place when displaying 5+ points :_). Progress is progress after all.

I still need to work on the route downloading scenario to help usability and waiting times until the fetching thing retrieves all the routes.

fincamd commented 4 years ago

This pr has a couple of bugs in it, I think it is not yet ready to be merged into development branch. Maybe if you guys could take a look to these bugs I have linked to the pr we can get to at least an idea on what might be going wrong. Keep up the good work :D.

They seem to be easy to solve. I will take a look to them later.

fincamd commented 4 years ago

Closes #161 Closes #162 Closes #163

codecov[bot] commented 4 years ago

Codecov Report

Merging #177 into development will decrease coverage by 4.82%. The diff coverage is 27.84%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #177      +/-   ##
===============================================
- Coverage        48.87%   44.04%   -4.83%     
===============================================
  Files               30       33       +3     
  Lines              487      647     +160     
  Branches            35       42       +7     
===============================================
+ Hits               238      285      +47     
- Misses             229      335     +106     
- Partials            20       27       +7
Impacted Files Coverage Δ
src/components/podService/podStoreHandler.js 8.47% <0.00%> (+0.57%) :arrow_up:
src/components/routeCreation/SearchBar.js 37.50% <0.00%> (-1.64%) :arrow_down:
src/model/RouteManager.js 100.00% <ø> (ø)
src/pages/InfoView.js 56.52% <0.00%> (ø)
src/pages/RouteCreation.js 63.46% <0.00%> (-1.93%) :arrow_down:
src/pages/RouteList.js 52.63% <21.05%> (-6.75%) :arrow_down:
src/model/MyRoute.js 60.00% <22.22%> (-4.48%) :arrow_down:
src/model/RoutePoint.js 78.94% <75.00%> (-8.56%) :arrow_down:
src/components/routeList/RouteCard.js 80.00% <80.00%> (-20.00%) :arrow_down:
src/components/navBar/navBar.js 38.09% <100.00%> (+4.76%) :arrow_up:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 495db3d...e788035. Read the comment docs.