search

Arquisoft / viade_en3a

Viade En3A
https://arquisoft.github.io/viade_en3a/
1 stars 4 forks source link

Login/Register feature & NavBar #56

Closed Drastur closed 4 years ago

Drastur commented 4 years ago

Here is included routing for the Nav bar, as well as login and register buttons. A link to this github repository.

This solves issue #36

jesQM commented 4 years ago

Here is included routing for the Nav bar

However, I couldn't find the HashRoutes, are we going then to create two PR for this (one the routing and another this one) or all in one? I know I have #52 open, but it can be closed without merge if all is to be added in the same pull request.

Drastur commented 4 years ago

My bad, forgot to push the last commit to this branch before creating this pull request.

The HashRoutes is inside the NavBar, inside the component. It wraps the navbar component. I put the Route component in the last line.

I dont know if it's possible to move it somewhere else. Any change can be debated.

And yes, it also closes #52