search

ArranzCNL / ImprovedCameraSE-NG

First Person Mod for The Elder Scrolls V: Skyrim - Special Edition
Mozilla Public License 2.0
28 stars 6 forks source link

Fix: Loading Time with Custom Window Mod #14

Closed Tondorian closed 7 months ago

Tondorian commented 7 months ago

The window detection code does not use the one from the config file but instead a hard coded one. This forces the game to wait 120sec. It also disables the menu. This pull request fixes this issue Tested on Enderal SE

ArranzCNL commented 7 months ago

Thankyou for your submission however the code you have submitted is for the logging directory so cannot be used as it is usually Skyrim Special Edition or Skyrim Special Edition GOG (Don't support VR hence that missing). If Enderal SE is saving data to it's own directory similar then yes we shall need to come up with a solution for that.

I just doubled check where the window check takes place Window.cpp Line 67 where it pulls the data about the window name from ImprovedCameraSE.ini then checked on Line 95.

Edit: I shall more than likely modify this somewhat as the reason for the window check was to acquire the size and position, I've seen the hWnd inside the exe enough that I can just capture this and do enquiries on it instead of relying on finding the window to capture the hWnd.

Tondorian commented 7 months ago

Enderal uses its custom location for saves "Enderal Special Edition" and you are also right it is checked in window.cpp. However without my changes, window detection does not work and i have to wait for a Timeout.

Tondorian commented 7 months ago

Nevermind, maybe I had another issue with MO2 and it does not use the correct config file. Enderal uses a custom folder for its saves, however no mod wrotes its log into it so it would be worse to be thee only mod to do this