ArrayHQ / atomic-blocks-theme

34 stars 14 forks source link

new gutenberg update #19

Closed overcatbe closed 6 years ago

overcatbe commented 6 years ago

breaks the sites pretty well. there is a dialog "try to restore", but it does nothing.

do you guys have a workaround perhaps? thanks much

mikemcalister commented 6 years ago

Hi there,

Can you send some more details about what you're seeing? I updated to the latest but it's not breaking on my end. The editor styles are a little off, but everything is functional. Please send some more details so we can take a look.

dartiss commented 6 years ago

I'm not seeing any issues either, other than the editor styles - the heading is particularly off right now. Do you plan on updating for this @mikemcalister?

mikemcalister commented 6 years ago

@dartiss Yep, fix coming soon.

overcatbe commented 6 years ago

hi, thanks for looking into it, here you go. i've installed the site anew without siteorigin plugin, and now just after enabling woocommerce - start page (without any woocommerce stuff) not editable anymore: TypeError: this.activateMode is not a function at http://localhost/better-aging.net/wp-includes/js/media-views.min.js?ver=4.9.8:1:24303 at arrayEach (webpack-internal:///67:516:11) at Function.forEach (webpack-internal:///67:9342:14) at n._createModes (http://localhost/better-aging.net/wp-includes/js/media-views.min.js?ver=4.9.8:1:24263) at n.initialize (http://localhost/better-aging.net/wp-includes/js/media-views.min.js?ver=4.9.8:1:23672) at n.initialize (http://localhost/better-aging.net/wp-includes/js/media-views.min.js?ver=4.9.8:1:25310) at n.initialize (http://localhost/better-aging.net/wp-includes/js/media-views.min.js?ver=4.9.8:1:28182) at n.e.View (http://localhost/better-aging.net/wp-includes/js/backbone.min.js?ver=1.2.3:1:14744) at n.constructor (http://localhost/better-aging.net/wp-includes/js/wp-backbone.min.js?ver=4.9.8:1:2616) at n.constructor (http://localhost/better-aging.net/wp-includes/js/media-views.min.js?ver=4.9.8:1:23119)

EDIT: sry forget it, my bad - the plugin which is causing the issue is the Advanced Gutenberg Blocks from maximebj. which is sad, cause it has a "section" like wrapper option with background and stuff :) but i'll live. Your atomic blocks do function well, thanks much for the wonderful theme btw :)

dartiss commented 6 years ago

Was 1.2.1 supposed to resolved this? Only I'm seeing no change with the title/body alignment.

mikemcalister commented 6 years ago

Alignment issues were fixed in version 1.2.2 which was just released. Thanks for the heads up!