Arrenton / KingdomHeartsPlugin

A Kingdom Hearts UI plugin for FFXIV (Dalamud)
19 stars 7 forks source link

Adds rudimentary Shield Overlay Functionality #52

Open roughk opened 1 month ago

roughk commented 1 month ago

adds shield overlay functionality. Accurately scales shield % based on user settings for rings and long bar.

image

Apologies for forking instead of making a merge request, I'm quite rusty on git after all my time on p4

roughk commented 1 month ago

I don't know how to do GitHub anymore, I intended to make the low mp change a separate branch and pull request lol

roughk commented 1 month ago

image

Arrenton commented 1 month ago

Code looks good. Although I would change the added party tab to be hidden until any features for that is implemented. Maybe since the EXP bar color is the same, we could change the texture to a white/grey color and allow the user to set the color for shield? One more thing: a transparency setting for the shield. I don't know how shields work in XIV, but if the shield is able to entirely cover the HP bar and cover missing HP, you'd might want to be able to see it.

roughk commented 1 month ago

party: accidentally committed that early with the portrait render order change zzz...

Shield bar: I color picked the shield color from xiv to make it as diegetic to kh and ff as possible despite being a mechanic not present in kh... I could look into setting a custom color as an option but I would prefer to handle new features rather than qol currently. I understand wanting to minimize wasteful textures, I am going to be using the health restored ring segments to represent mana in parties.

transparency: I entirely agree. The potential for HP not being visible under the Shield can potentially be seen as a downside and I should include a transparency % slider. I do want to focus on new features since the shield is opt-in.

roughk commented 1 month ago

@Arrenton alright the party hud base implementation is in. Should be good to go.

roughk commented 1 month ago

image