ArroyoSystems / arroyo

Distributed stream processing engine in Rust
https://arroyo.dev
Apache License 2.0
3.8k stars 220 forks source link

urlencode subject in confluent schema registry URLs #759

Closed emef closed 1 month ago

emef commented 1 month ago

thank you for the recent protobuf support! while testing this, I received some 404 errors while creating a kafka source that are caused by subject names that include slashes. this happens when a protobuf schema definition includes imports to other proto files in different directories (the subject will be the file path of the import)

mwylde commented 1 month ago

Hey @emef — appreciate your efforts debugging the CI issues. I don't think increasing the number of retries will help, as there seems to be some fatal error with the pipeline process; possibly it's being OOM killed, but unfortunately the CI system doesn't give us good logs on that.

It does seem to be running successfully now, so it may have been some temporary instability on the side of our action runner provider (ubicloud).

If you back out the retry changes we should be able to get this merged.