search

ArroyoSystems / arroyo

Distributed stream processing engine in Rust
https://arroyo.dev
Apache License 2.0
3.8k stars 220 forks source link

feat: make heap profiling as default #766

Closed zhuliquan closed 3 weeks ago

zhuliquan commented 4 weeks ago

Sometimes, we need to analyze the memory usage of workers or controllers, and pprof is a very useful tool for this. I believe it should be included as a default feature rather than an optional compile-time setting. Additionally, it doesn't make much sense to expose an HTTP route if it can't be utilized effectively (i.g: #764 ).

mwylde commented 4 weeks ago

I think it would be good to disable the HTTP route if profiling isn't enabled, or return a more helpful error there. Also adding it as an option to the Dockerfile makes sense, although we probably wouldn't want it enabled by default since that would hurt compatibility and perf.