Ars-Linguistica / mlconjug3

A Python library to conjugate verbs in French, English, Spanish, Italian, Portuguese and Romanian (more soon) using Machine Learning techniques.
MIT License
69 stars 10 forks source link

several Spanish conjugation need to add Spanish word 'haber' #503

Open CalvinJulo opened 10 months ago

CalvinJulo commented 10 months ago

First of all, thanks for your great work

I am learning Spanish, and my main dictionary is wordreference.com I compare the conjugation of mlconjug3 to wordreference, I think there are several mode tense they are different.

Take an example

The Indicativo pretérito perfecto of Spanish word 'armar' wordreference mlconjug3
yo he armado armado
has armado armado
él, ella, usted ha armado armado
nosotros, nosotras hemos armado armado
vosotros, vosotras habéis armado armado
ellos, ellas, ustedes han armado armado

wordreference is right, some Spanish conjugation need to add Spanish word 'haber' , so mlconjug3 need to change the conjugation

The similar problem, other mode tense mlconjug3 has, as following image

SekouDiaoNlp commented 8 months ago

Hi @CalvinJulo thanks for submitting this issue.

Indeed the full conjugated forms of some verbs need to have the auxiliary « ser » or « haber » prepended to the conjugated form.

I was not sure wether I should include the auxiliary in the output of the software, but now I agree it should be there. I will add this feature to the software promptly and let you know as soon as it’s implemented.

Cheers.