ArsenAbazian
commented
2 years ago Hi!
From the perspective of program logic, adding "Binance Futures" Exchange has minimal changes. I just need to copy a copy of Binance's Exchange module code, register it as a new Exchange, and then replace all the API addresses in the function with Futures API. However, this does not conform to the business logic.
I like this approach more. I started already to add a new Binance Future Exchange which is a descendant of BinanceExchange. While I did not implement all functionality (missed while Buy, Sell e.t.c), it already lists all tickers from the exchange, shows order book, and trade history. It is not difficult to add missed functionality, but it takes time.
However, I found a bug (showstopper) in CryptoMarketClient while tested BinanceFutures. When you open the ticker's screen (chart and order book) after several seconds exception is raised.
I need time to fix it. BTW I updated the project so you can start to use BinanceFutures Exchange.
Thanks, Arsen.
xyong6024
xiuxiang
Hello, I'm a little tangled after studying the code. I want to add the Futures module of Binance, so I should add a new Exchange "Binance Futures" or add a Futures market in "Binance Exchange".
From the perspective of program logic, adding "Binance Futures" Exchange has minimal changes. I just need to copy a copy of Binance's Exchange module code, register it as a new Exchange, and then replace all the API addresses in the function with Futures API,However, this does not conform to the business logic.
which will lead to one more exchange for every Futures added to a Exchange platform. However, if I add a future market in "Binance" exchange, because I refer to the same exchange class module, I will copy all the original functions, resulting in two sets of functions with the same function in the same Class, This is not in line with the development idea and is not conducive to expansion, so I want to ask you what is the most appropriate, thanks