search

ArsenalRecon / Arsenal-Image-Mounter

Arsenal Image Mounter mounts the contents of disk images as complete disks in Microsoft Windows.
https://ArsenalRecon.com/weapons/image-mounter
Other
496 stars 85 forks source link

LGPL license missing for redistribution of libewf #19

Closed joachimmetz closed 3 years ago

joachimmetz commented 3 years ago

The LGPL license is missing for redistribution of libewf in https://github.com/ArsenalRecon/Arsenal-Image-Mounter/tree/master/libewf

Also likely missing are licenses for the Visual C++ Files https://docs.microsoft.com/en-us/cpp/windows/redistributing-visual-cpp-files?view=msvc-160

joachimmetz commented 3 years ago

And you likely want to add the license of zlib as well

LTRData commented 3 years ago

Thanks for noticing this. Added updated libewf.dll files with a license document.

joachimmetz commented 3 years ago

Thx for the quick changes, though I think that technically you still need to include a copy of the LGPL as well Per https://www.gnu.org/licenses/gpl-faq.html#WhyMustIInclude 

Why does the GPL require including a copy of the GPL with every copy of the program? (#WhyMustIInclude)
Including a copy of the license with the work is vital so that everyone who gets a copy of the program can know what their rights are.

It might be tempting to include a URL that refers to the license, instead of the license itself. But you cannot be sure that the URL will still be valid, five years or ten years from now. Twenty years from now, URLs as we know them today may no longer exist.

The only way to make sure that people who have copies of the program will continue to be able to see the license, despite all the changes that will happen in the network, is to include a copy of the license in the program.

Which to my knowledge also applies to the AGPL of the main source

LTRData commented 3 years ago

Okay, I copied the LGPL license to a document called LICENSE in libewf directory, but maybe we should mention it in the license document for the whole repo as well. I also agree that we definitely should keep a copy of the full AGPL license in the repo as well. We will fix this! Thank you!

joachimmetz commented 3 years ago

That could work what I do for libewf itself have a copy of the LGPL and GPL (since the LGPL references the GPL license). Another common approach is to have a license directory with all the license information for the repo

joachimmetz commented 3 years ago

Can you also make sure to include the license in https://arsenalrecon.com/downloads/ and that of Dokan as well

joachimmetz commented 3 years ago

Can you also include a text file that indicate which version are used and what compiler was used to build them. It looks like you're using the bleeding edge development version in your zip file, which is NOT recommended.

LTRData commented 3 years ago

I have now created a Third-Party-Licenses subfolder with licenses and a brief description of where a particular dll comes from and in which environment and toolchain it was built. Mark has also updated distribution packages for the GUI application so that they contain the license documents directly in the package too.

joachimmetz commented 3 years ago

Ack and I see a copy of lgpl-3.0.txt, so that looks to me.

And it is transparent now, how and what is built.

Thx

LTRData commented 3 years ago

All good then I think. Thank you for bringing this to our attention!