search

ArsenyYankovsky / typeorm-aurora-data-api-driver

A bridge between TypeORM and Aurora Data API
MIT License
175 stars 38 forks source link

Support scale and precision in numeric casting #113

Closed fargito closed 3 years ago

fargito commented 3 years ago

Hello and thanks for this awesome project !

I have noticed a small bug when using DECIMAL data types : the cast operation removed any floating-point digit.

I think the cause was the cast to DECIMAL (without precision), so I added this support.

Hope this helps !

fargito commented 3 years ago

Hello @ArsenyYankovsky, I'm not really sure why the tests fail, but I saw that the same tests were failing on other PRs as well, do you think I need to fix them ?

ArsenyYankovsky commented 3 years ago

@fargito Thanks for your PR. I'll check it later today. You don't need to fix the tests, I will need to actually fix the CI config so that the tests could be run on PRs.

ArsenyYankovsky commented 3 years ago

:tada: This PR is included in version 2.3.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

fargito commented 3 years ago

Thanks a lot !