search

Art-and-Rare-Materials-BF-Ext / arm

BIBFRAME extension ontologies for modeling bibliographic metadata in the art and rare materials domains.
4 stars 3 forks source link

Review New Terms Added #8

Open ruthtillman opened 3 years ago

ruthtillman commented 3 years ago

Sign off below in comments

Review:

Ensure that they are appropriately subclassed and related to any other classes & properties.

timathom commented 3 years ago

The physical state of the resource (e.g. rolled, folded, unframed) or other aspects of the resource (eg.g. initial letters or illustrations on a single page) when a measurement is taken.

I'm not so sure about the second part ("or other aspects for the resource") and don't recall discussing this idea within the scope of the property. I'd suggest shortening to:

The physical state of the resource (e.g. rolled, folded, unframed) when a measurement is taken.

erussey commented 3 years ago

@timathom : the physicalPresentation definition came from an email discussion on 9/23 from Linda Isaac. She suggested adding the second part: "Could we also think about expanding the definition a bit (for clarity) to include other elements of a resource (i.e., mis-en-page or typography)? Perhaps something like, "The physical state of the resource (e.g., rolled, folded, unframed) or other aspects of the resource (e.g., initial letters or illustrations on a single page) when a measurement is taken."

timathom commented 3 years ago

Ah, thanks. Looking at this now, I don't think the addition serves to clarify the definition and seems to juxtapose two different concepts.

jak473 commented 3 years ago

Made some changes to align with 12/14 (merged the PRs since these were action items for me from the meeting... and to avoid having too many concurrent edits on the file). Reviewed per the spreadsheet and think this is done. From my POV, we can close the issue