Art-of-WiFi / UniFi-API-client

A PHP API client class to interact with Ubiquiti's UniFi Controller API
MIT License
1.13k stars 223 forks source link

add a basic protect client #102

Closed revoltek-daniel closed 2 years ago

revoltek-daniel commented 3 years ago

Add a basic protect API client based on the controller API client.

I've made only a little change on the current class.

I don't know if it matters that the codestyle differs, this is the class i used in my environment i want to share because i think somebody could use it as well. So feel free to modify it if the codestyle matters.

malle-pietje commented 3 years ago

Thanks for the PR, it’s quite similar to what I’ve done for a couple of small projects. There I mostly worked with the /bootstrap endpoint. I’ll have a look at the code, but I reckon it will require some additional documentation.

BTW, I personally also prefer the camelCase method names but had to stick with the initial standards chosen by the first devs for backward compatibility purposes. Probably something for version 2.0.0 of the client😉

malle-pietje commented 3 years ago

Thanks, looking good so far.