search

Art-of-WiFi / UniFi-API-client

A PHP API client class to interact with Ubiquiti's UniFi Controller API
MIT License
1.09k stars 217 forks source link

fix create_radius_account function #148

Closed CodeByJacob closed 2 years ago

CodeByJacob commented 2 years ago

Fix create_radius_account function because the function don't allowed us to set different values on tunnel_type and tunnel_medium_type ( it caused by "($tunnel_type ^ $tunnel_medium_type)" condition). Now you can set this values different ( like in dashboard)

malle-pietje commented 2 years ago

@CodeByJacob thanks for the PR. I'd like to ask what @mreho 's thoughts are because that piece of code was contributed by him.

malle-pietje commented 2 years ago

This was the commit in the PR where that part was added: https://github.com/Art-of-WiFi/UniFi-API-client/pull/122/commits/d4dffbf76816e161c5d14253c5b840fb6baa665d

malle-pietje commented 2 years ago

I am accepting this PR and will merge it manually in the next release since we haven't heard back from @mreho

CodeByJacob commented 2 years ago

@malle-pietje Thanks, It is great to hear it

malle-pietje commented 2 years ago

Fixed in this release: https://github.com/Art-of-WiFi/UniFi-API-client/releases/tag/v1.1.78