Add effect type to data and look it up

ArtOfShred / LuiExtended

Lui Extended addon for ESO

http://www.esoui.com/downloads/fileinfo.php?id=818

Other

36 stars 21 forks source link

Add effect type to data and look it up #197

Closed andrewspiers closed 3 years ago

andrewspiers commented 3 years ago

re issue #196

local effectType was not set in this context, causing an error like: user:/AddOns/LuiExtended/modules/SpellCastBuffs/SpellCastBuffs.lua:2406: operator .. is not supported for string .. nil

I'm not sure if its better to put the type in the Effects module and then look it up or just hardcode it into 'context' in SpellCastBuffs.OnCombatEventIn

ArtOfShred commented 3 years ago

Good catch. Actually gonna close this pr though, effectType doesn't even need to be set. I can just set the context to "player1" since this is always a buff.