search

ArtOfShred / LuiExtended

Lui Extended addon for ESO
http://www.esoui.com/downloads/fileinfo.php?id=818
Other
36 stars 21 forks source link

Added New AOEs to AOE Tracker Dataset #226

Closed ACastanza closed 12 months ago

ACastanza commented 1 year ago

Add Dark Convergence and Rush of Agony to Player Set AOEs (working but needs to be whittled down to just the necessary ones, but the datamine doesn't have enough detail to do it preemptively) Added Rune of Displacement, Fatecarver, and Abyssal Impact/morphs to Player skill AOEs. Added Unblinking Eye/morphs to Player Ult AOEs

saenic commented 1 year ago

Thanks for the IDs. Can this be merged or are you still working on it?

ACastanza commented 1 year ago

It is working as-is and the extra IDs don't cause any issues. So, it can be merged now, but at some point I'll have an additional PR that will prune out the IDs that the game doesn't actually use. You could wait until I get that done but it could take some time for me to work through the testing.

Edit: removed a couple that never came up while testing tonight

ACastanza commented 1 year ago

Moved up Dark Convergence to a slightly higher priority tier, as well as bumping the priority of Proc Sets overall, given their significant strength in the current meta. Also added the snare and immobilize from the Nunatak monster set. This can be merged at any time.

You might see additional changes, they are going to be adding effects to the ignorelist table that appear as CC's or AoE's in PVP but are not, and shouldn't be alerted. This has been a longstanding issue as a result of incorrectly coded ability metadata game-side, and I finally wrote a private function (not committed to the repo) that will log them so I can ignorelist them. They are fine to merge as well.

ACastanza commented 1 year ago

@saenic since this is still open it has also just now picked up my updates for the new IDs for Merciless Resolve (and morphs) and Bound Armaments.

saenic commented 12 months ago

@ACastanza Can you tell me when you are done (or feel like you are done) so I can merge it? I won't have much time in the near future so I'd like to get this done.

ACastanza commented 12 months ago

@saenic It can be merged as-is.

The only one of the new CC IDs that was causing problems was Runeguard of Still Waters which was triggering an alert from allied effects. I just disabled that one in the last push.

The ignorelist functionality seems to be working well with the new IDs there are a lot less erroneous alerts.

There are some immobilizes which are not getting alerted for, but I haven't found the IDs for them and don't know when I might.

Its in a good place, any other changes can wait until the next time you're ready to do a release down the line.