search

ArtOfShred / LuiExtended

Lui Extended addon for ESO
http://www.esoui.com/downloads/fileinfo.php?id=818
Other
36 stars 21 forks source link

code cleanup #227

Closed DakJaniels closed 11 months ago

DakJaniels commented 11 months ago

Changelog

Updated modules\UnitFrames\UnitFrames.lua

Updated UI.lua, Unlock.lua, modules\CombatInfo\AbilityAlerts.lua, modules\CombatInfo\CombatInfo.lua, modules\InfoPanel\InfoPanel.lua, modules\SpellCastBuffs\SpellCastBuffs.lua, modules\UnitFrames\UnitFrames.lua, settings\CombatInfo.lua

Details:

DakJaniels commented 11 months ago

I don't know how to set the changelog for the game so someone else could do that please.

DakJaniels commented 11 months ago

changelog.

modules\UnitFrames\UnitFrames.lua -- depreciated table function -- table.foreach({ LFG_ROLE_TANK, LFG_ROLE_HEAL, LFG_ROLE_DPS, LFG_ROLEINVALID }, function(, value) insertRole(playerList, value) end) replaced with a ipairs iterator instead of a table.foreach

local roles = { LFG_ROLE_TANK, LFG_ROLE_HEAL, LFG_ROLE_DPS, LFG_ROLE_INVALID }
for _, value in ipairs(roles) do
    insertRole(playerList, value)
end

Adjusted numerous DrawTier and DrawLevel errors that fixed the action bar timers being usable again. so that is turned on as well

UI.lua Unlock.lua modules\CombatInfo\AbilityAlerts.lua modules\CombatInfo\CombatInfo.lua modules\InfoPanel\InfoPanel.lua modules\SpellCastBuffs\SpellCastBuffs.lua modules\UnitFrames\UnitFrames.lua settings\CombatInfo.lua

Fixed some globals that should have been local in the following files.

Hooks.lua

saenic commented 11 months ago

Thanks for the cleanup. I'll merge it and create a new version.

Will look at the ability timers but I guess they need a rewrite using the ingame timers as base instead of tracking every ability (because this needs a lot of work with abilityIds).