ability proc sound broken

ArtOfShred / LuiExtended

Lui Extended addon for ESO

http://www.esoui.com/downloads/fileinfo.php?id=818

Other

36 stars 21 forks source link

ability proc sound broken #228

Closed necco889 closed 11 months ago

necco889 commented 11 months ago

Hey, the sound notification on ability procs are not playing like crystal frags, etc The reason is this change, the global variable got a local qualifier between 6.5.0 and 6.5.1 for some reason

https://github.com/ArtOfShred/LuiExtended/blame/c39733398218bd041e19a47900f28d645d5c026a/modules/CombatInfo/CombatInfo.lua#L1187

DakJaniels commented 11 months ago

I have this fixed in my brach. Working on some other changes before sending in the pull request though. Feel free to use mine in the interim.

necco889 commented 11 months ago

tested on the master branch and it works again thx!