search

ArtOfShred / LuiExtended

Lui Extended addon for ESO
http://www.esoui.com/downloads/fileinfo.php?id=818
Other
36 stars 21 forks source link

dont use ZOS namespace for localization #257

Closed psypanda closed 9 months ago

psypanda commented 9 months ago

According to the wiki addons shouldn't use the SI_ namespace since this is considered ZOS namespace.

You shouldn't use SI_ as the beginning of the unique indeitifer as this is ZOs namespace!

DakJaniels commented 9 months ago

I am checking this out. @ArtOfShred would certainly have to approve this though. These were missed from what I can tell from some initial in game string dumps.

["SI_BINDING_NAME_LUIE_COMMAND_ARMORY"]      
["SI_BINDING_NAME_LUIE_COMMAND_AZANDAR"]     
["SI_BINDING_NAME_LUIE_COMMAND_BANKER"]      
["SI_BINDING_NAME_LUIE_COMMAND_BASTIAN"]     
["SI_BINDING_NAME_LUIE_COMMAND_DECON"]       
["SI_BINDING_NAME_LUIE_COMMAND_EMBER"]       
["SI_BINDING_NAME_LUIE_COMMAND_EYE"]         
["SI_BINDING_NAME_LUIE_COMMAND_FENCE"]       
["SI_BINDING_NAME_LUIE_COMMAND_HOME"]        
["SI_BINDING_NAME_LUIE_COMMAND_ISOBEL"]      
["SI_BINDING_NAME_LUIE_COMMAND_LEAVE_GROUP"] 
["SI_BINDING_NAME_LUIE_COMMAND_MERCHANT"]    
["SI_BINDING_NAME_LUIE_COMMAND_MIRRI"]       
["SI_BINDING_NAME_LUIE_COMMAND_OUTFIT_1"]    
["SI_BINDING_NAME_LUIE_COMMAND_OUTFIT_10"]   
["SI_BINDING_NAME_LUIE_COMMAND_OUTFIT_2"]    
["SI_BINDING_NAME_LUIE_COMMAND_OUTFIT_3"]    
["SI_BINDING_NAME_LUIE_COMMAND_OUTFIT_4"]    
["SI_BINDING_NAME_LUIE_COMMAND_OUTFIT_5"]    
["SI_BINDING_NAME_LUIE_COMMAND_OUTFIT_6"]    
["SI_BINDING_NAME_LUIE_COMMAND_OUTFIT_7"]    
["SI_BINDING_NAME_LUIE_COMMAND_OUTFIT_8"]
["SI_BINDING_NAME_LUIE_COMMAND_OUTFIT_9"]
["SI_BINDING_NAME_LUIE_COMMAND_READY_CHECK"]
["SI_BINDING_NAME_LUIE_COMMAND_REGROUP"]
["SI_BINDING_NAME_LUIE_COMMAND_RELOADUI"]
["SI_BINDING_NAME_LUIE_COMMAND_SHARP"]
["SI_BINDING_NAME_LUIE_DISMISS_PET"]
["SI_LUEI_SET_STONE_HUSK_BUFF_TP"]
psypanda commented 9 months ago

closing in favor of #258