Fix Swift PM 5.3 Resource Bundle Migration

ArtSabintsev / Siren

Notify users when a new version of your app is available and prompt them to upgrade.

http://sabintsev.com/

MIT License

4.25k stars 407 forks source link

Fix Swift PM 5.3 Resource Bundle Migration #358

Closed ArtSabintsev closed 3 years ago

ArtSabintsev commented 3 years ago

This PR fixes a longstanding issue around localization for Swift PM users. Since Swift PM 5.3's can now explicitly bring in bundlers, localization should not work with users installing Siren using Swift PM v5.3.

Thanks to #357 for bringing this issue to light.

Robuske commented 3 years ago

@ArtSabintsev , I was looking at somethings and realized that you used copy here, and from what I understood of what is said here, using processing would be better

ArtSabintsev commented 3 years ago

Processing didn't work.

Robuske commented 3 years ago

Well, ok them 😄