ArtSabintsev / Siren

Notify users when a new version of your app is available and prompt them to upgrade.
http://sabintsev.com/
MIT License
4.26k stars 407 forks source link

App update availability delay #381

Closed dimazen closed 2 years ago

dimazen commented 2 years ago

If you're experiencing a problem integrating Siren into your app, please provide the following information when posting a new issue:


Despite this issue being answered before, there is major issue: During building of the iTunes request, country argument needs to be changed. I understand that the way you name argument comes from an iTunes Search API, but it has been archived for a while. In this way, I can get latest results right away, while with country I'm getting an old results.

For example:

$ curl https://itunes.apple.com/lookup\?bundleId\=com.my.bundle\&country\=US | grep 'version'

responds me with

... "version":"2.5.3" ...

while after a small change I'm getting correct results:

$ curl https://itunes.apple.com/US/lookup\?bundleId\=com.my.bundle | grep 'version'
// this is also a valid change
$ curl https://itunes.apple.com/lookup\?bundleId\=com.my.bundle\&country\=no | grep 'version'

returns

... "version":"2.6.0" ...

Can this be addressed, please?

ArtSabintsev commented 2 years ago

This only works if an app is available in a specific country. The default is US. There is a property that's let's you change countryCode on APIManager, I think.

I'm on mobile so I can't confirm at the moment.