search

ArtSabintsev / Siren

Notify users when a new version of your app is available and prompt them to upgrade.
http://sabintsev.com/
MIT License
4.24k stars 407 forks source link

Siren localization .croatian #395

Closed agale92 closed 2 years ago

agale92 commented 2 years ago

Hi, Pls change localization for croatian:

/ Update alert message: A new version of {APP NAME} is available. Please update to version {NEW VERSION} now./ "A new version of %@ is available. Please update to version %@ now." = "Nova verzija %@ je dostupna. Ažuriraj na verziju %@ sada.";

/ Update alert title / "Update Available" = "Novo ažuriranje je stiglo";

/ Update alert dismiss button title / "Next time" = "Sljedeći put";

/ Update alert skip button title / "Skip this version" = "Preskoči ovu verziju";

/ Update alert skip button title / "Update" = "Ažuriraj";

Thank you.

Best regards

ArtSabintsev commented 2 years ago

Hey @jinjic - you did the original localization. Can you comment here.

jinjic commented 2 years ago

yes I see there is a minor error in the first line. "Update alert message..." So the suggested line is correct.

In the second line it should be updated to the masculine gender noun. But instead of saying "Update Available" = "Novo ažuriranje je stiglo" as suggested I think we should actually change it to "Update Available" = "Novo ažuriranje je dostupno"

The rest of the translation and suggestions match.

agale92 commented 2 years ago

yes that's fine. Pls change text in localization.

/ Update alert message: A new version of {APP NAME} is available. Please update to version {NEW VERSION} now./ "A new version of %@ is available. Please update to version %@ now." = "Nova verzija %@ je dostupna. Ažuriraj na verziju %@ sada.";

/ Update alert title / "Update Available" = "Novo ažuriranje je dostupno";

/ Update alert dismiss button title / "Next time" = "Sljedeći put";

/ Update alert skip button title / "Skip this version" = "Preskoči ovu verziju";

/ Update alert skip button title / "Update" = "Ažuriraj";

ArtSabintsev commented 2 years ago

Can you open a PR

ArtSabintsev commented 2 years ago

No problem - I can wait until your laptop is fixed for you to open a PR with the changes and updates tests.

Thanks!

ArtSabintsev commented 2 years ago

Fixed just now. Will be pushing a new version momentarily. Thanks again.