search

ArtSabintsev / Siren

Notify users when a new version of your app is available and prompt them to upgrade.
http://sabintsev.com/
MIT License
4.26k stars 407 forks source link

Help resolving a version number mistake #409

Closed nickvelloff closed 1 year ago

nickvelloff commented 1 year ago

I have been using this for a while and appreciate the work!

I made a dumb mistake, and I'm struggling to find a way out of it. I left a decimal point out of the version number and it made it into the app store. 2.0028 was supposed to be 2.00.28

Interestingly with versions like 2.00.29 and even 3.00.00 it recognizes 2.0028 as a newer version.

Screenshot 2023-05-03 at 7 35 14 PM

Given Apple isn't going to allow me to correct this version, I was hoping you could help me out.

Version 3.00.00 <<-- Even this one shows alert to update to 2.0028 Version 2.00.29 <<-- Shows alert to update to 2.0028 Version 2.0028 <<-- OOPS! Version 2.00.27 Version2.00.26 Version 2.00.25

ArtSabintsev commented 1 year ago

hey - the logic for this is found here: https://github.com/ArtSabintsev/Siren/blob/master/Sources/Utilities/DataParser.swift#L69

You may want to see why 2.0028 overrides every new version, even 3.